Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for cursor being locked and grabbed on Windows #6

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Adds support for cursor being locked and grabbed on Windows #6

merged 1 commit into from
Jun 4, 2024

Conversation

Hoodad
Copy link

@Hoodad Hoodad commented Jun 4, 2024

Applied the patch as stated in #3711 in Winit

@Hoodad Hoodad requested a review from rib June 4, 2024 13:53
@dbartussek @rib
Implemented CursorGrabMode::Locked for Windows
79a6da6 
--
Cherry-picked-from: rust-windowing#3711
Cherry-picked-by: Robin Thunstrom <[email protected]>
@rib rib force-pushed the rt/cursor-grabbed-locked branch from b34d807 to 79a6da6 Compare June 4, 2024 21:04
rib
rib approved these changes Jun 4, 2024
View reviewed changes
Copy link

@rib rib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me. I just amended the commit to keep the original author attribution but noted in the message where the change is from and attributed you as having cherry-picked the change across to this branch. I also ran cargo fmt.

@rib rib merged commit bf68f63 into embark-0.29 Jun 4, 2024
21 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rib rib rib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoodad @rib @dbartussek