Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply room gradle plugin #370

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Apply room gradle plugin #370

merged 1 commit into from
Feb 24, 2025

Conversation

runningcode
Copy link
Contributor

This will generate the database schema in a build caching compatible way.
This also generates the database code in Kotlin to save java
compilation.

Clean up buildscript classpath.
Remove deprecated flag which is now enabled by default.

This will generate the database schema in a build caching compatible way.
This also generates the database code in Kotlin to save java
compilation.

Clean up buildscript classpath.
Remove deprecated flag which is now enabled by default.
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

# Enables namespacing of each library's R class so that its R class includes only the
# resources declared in the library itself and none from the library's dependencies,
# thereby reducing the size of the R class for that library
android.nonTransitiveRClass=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is enabled by default with AGP 8.0+ so I removed it.

}

composeCompiler {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is enabled by default as of Kotlin 2.020 so I removed it.

Copy link

emerge-tools bot commented Feb 24, 2025

🛰️ Build Distribution

Build available for installation

App Name App ID Platform Version Tag Install Page
Hacker News com.emergetools.hackernews android 1.0.2 release 🔗 Install Build

🛸 Powered by Emerge Tools

Copy link
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@runningcode runningcode merged commit 1809379 into main Feb 24, 2025
7 checks passed
@runningcode runningcode deleted the no/apply_room_gradle_plugin branch February 24, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants