Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed fallthrough case since it caused build errors #739

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

kori-irrlicht
Copy link
Contributor

I removed the fallthrough statement. Otherwise it already looked like the glfw version, so I think this should be the necessary changes to fix the compile error I received in #738

There is still another problem with the headless build: The oto dependency is causing trouble, if no drivers are installed on a build system. But I'm not sure if this should be fixed in this pull request (or even in this repository)

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 37.325% when pulling d3e25cd on kori-irrlicht:fix_headless_build into c5b322f on EngoEngine:master.

@coveralls
Copy link

coveralls commented Aug 6, 2020

Coverage Status

Coverage increased (+1.2%) to 38.512% when pulling 2818088 on kori-irrlicht:fix_headless_build into 79b3599 on EngoEngine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 28.2% when pulling d3e25cd on kori-irrlicht:fix_headless_build into c5b322f on EngoEngine:master.

@Noofbiz
Copy link
Member

Noofbiz commented Aug 6, 2020

The failures are not due to anything you did, and the PR looks good to me. Also, fixing oto should be relatively easy, just have to use the same method we do for running tests. Try building it with engo.RunOptions has Headless = true. That should skip over oto and use a fake readwriteseeker instead of oto

@Noofbiz Noofbiz merged commit 166fb92 into EngoEngine:master Aug 6, 2020
@Noofbiz
Copy link
Member

Noofbiz commented Aug 6, 2020

Thanks for the help! Let me know if the headless option works!

@kori-irrlicht
Copy link
Contributor Author

Thanks for the hint, but I was already using the headless option and the error occurs while building the project. Would it be possible to skip the oto dependency this way?
I can build it on my machine, but building it on a build server causes an error, because it can't find the alsa package required by the Linux drivers of oto.

For now, I created a workaround by forking oto and adding an empty driver, which will ignore everything. It works for me, but I'm not sure if this is the best solution overall.

The error message:

Package alsa was not found in the pkg-config search path.
Perhaps you should add the directory containing 'alsa.pc'
to the PKG_CONFIG_PATH environment variable
No package 'alsa' found
pkg-config: exit status 1

If it would help, I can also post a link to my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants