Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Crew Alignments #1450

Open
wants to merge 3 commits into
base: dev_2.3.0
Choose a base branch
from

Conversation

MargaretTheFool
Copy link
Contributor

added investigative and protective role types, moved roles accordingly, and added crew investigative roles can be guessed setting (defaults to on)
@Tommy-XL Tommy-XL added the Some change Added when small changes are made label Feb 7, 2025
@Tommy-XL Tommy-XL marked this pull request as draft February 13, 2025 14:57
@Tommy-XL Tommy-XL changed the title Change Crew Alignments (For 2.3.0?) Change Crew Alignments Feb 21, 2025
@Tommy-XL Tommy-XL changed the base branch from dev_2.2.0 to dev_2.3.0 February 21, 2025 07:18
@MargaretTheFool MargaretTheFool marked this pull request as ready for review February 23, 2025 17:59
@NikoCat233 NikoCat233 requested a review from Copilot March 1, 2025 13:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request changes crew role alignments to better reflect investigative and protective functions while updating related UI option texts and configurations.

  • Introduces a new option (CrewInvestCanBeGuessed) for investigative roles.
  • Updates text option identifiers and role type assignments for several crew roles (e.g., Detective, Celebrity, Coroner, etc.).
  • Adjusts the Custom_RoleType enum to include the new investigative and protective types and modifies the GuessManager's logic accordingly.

Reviewed Changes

File Description
Modules/OptionHolder.cs Added a new option (CrewInvestCanBeGuessed) and updated text option labels.
Modules/GuessManager.cs Added condition to display a message for investigative roles based on new option.
Roles/Crewmate/*.cs Updated ThisRoleType properties for various crew roles to reflect new alignments.
Modules/CustomRolesHelper.cs Modified Custom_RoleType enum to include CrewmateInvestigative and CrewmateProtective.

Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

Modules/OptionHolder.cs:546

  • [nitpick] Consider renaming 'CrewInvestCanBeGuessed' to 'CrewInvestigativeCanBeGuessed' for improved clarity and consistency with the new role type naming.
public static OptionItem CrewInvestCanBeGuessed;

Modules/GuessManager.cs:281

  • Consider adding parentheses to clarify the operator precedence in this condition to ensure that the intended logic is correctly applied.
if (role.IsTNA() && role != CustomRoles.Pestilence && !Options.TransformedNeutralApocalypseCanBeGuessed.GetBool() || role == CustomRoles.Pestilence && !PlagueBearer.PestilenceKillsGuessers.GetBool())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Some change Added when small changes are made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants