Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. minor dev #181

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Misc. minor dev #181

wants to merge 4 commits into from

Conversation

muffato
Copy link
Contributor

@muffato muffato commented Dec 1, 2020

Use case

A collection of minor changes I have locally: bugfixes and new features

Description

  1. bugfix: avoid Perl's warning about undefined values.
  2. New SQL view similar to progress, which shows which analysis created each job. The view is not enabled yet because I didn't want to create a new schema version just for that right now. If you want to keep the view, a patch can be added now, or later, bundled with another schema change so that users of the master branch don't see too many changes.
  3. Moved the housekeeping .t tests into their own directory
  4. Fixed the executable bit of two .t

Possible Drawbacks

None

Testing

Have you added/modified unit tests to test the changes?

If so, do the tests pass/fail?

Have you run the entire test suite and no regression was detected?

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #181 (5bca20e) into master (cacc3e4) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   82.83%   82.78%   -0.05%     
==========================================
  Files         184      184              
  Lines       10557    10557              
  Branches     1660     1660              
==========================================
- Hits         8745     8740       -5     
- Misses       1125     1126       +1     
- Partials      687      691       +4     
Impacted Files Coverage Δ
modules/Bio/EnsEMBL/Hive/Worker.pm 67.67% <ø> (-0.28%) ⬇️
t/03.scripts/peekJob_output.t 100.00% <ø> (ø)
t/03.scripts/tweak_pipeline_output.t 100.00% <ø> (ø)
t/00.housekeeping/apache2.t 73.21% <100.00%> (ø)
t/00.housekeeping/ascii.t 73.17% <100.00%> (ø)
t/00.housekeeping/perlcritic.t 77.77% <100.00%> (ø)
modules/Bio/EnsEMBL/Hive/TheApiary.pm 82.85% <0.00%> (-5.72%) ⬇️
modules/Bio/EnsEMBL/Hive/Valley.pm 91.95% <0.00%> (-1.15%) ⬇️
modules/Bio/EnsEMBL/Hive/Queen.pm 70.12% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cacc3e4...5bca20e. Read the comment docs.

@muffato muffato force-pushed the feature/misc_dev branch 2 times, most recently from bba20b0 to 990dffa Compare December 15, 2020 12:51
@muffato muffato marked this pull request as ready for review March 14, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant