Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs because of meadow deprecations #232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sgiorgetti
Copy link
Contributor

Use case

We have deprecated eHive support for some job scheduler, and consequently eHive meadows.
Docs need updating to reflect these changes.

Possible Drawbacks

None

Testing

N/A

@sgiorgetti sgiorgetti marked this pull request as ready for review October 17, 2024 08:56
@sgiorgetti
Copy link
Contributor Author

@TamaraNaboulsi - would you mind to have a look at this?
The majority of examples in the entire doc set is based on LSF for historical reasons.
TBH, I applied minimum changes and unsure if adequate - especially on docs/running_pipelines/management.rst.
Does it make sense? Pls, comment and criticise at will. Thanks

Copy link
Contributor

@EbiArnie EbiArnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely and improvement over the status quo.
OK from my side.

Copy link
Member

@TamaraNaboulsi TamaraNaboulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much needed docs update now that SLURM is the default rather than LSF. Changes look good and are very descriptive.
Concerning "management.rst", it does still contain multiple mentions of LSF. However, these mentions are used in examples of hive operations (like beekeeper output) and thus the actual information there doesn't change whether it is LSF or SLURM. It would be nice to change these later on just so the operations of the users look like the examples here, but it's not super important for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants