Mongoengine genome #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoooo
reviewed
Mar 22, 2022
| @@ -0,0 +1,87 @@ | |||
| """ | |||
| .. See the NOTICE file distributed with this work for additional information | |||
There was a problem hiding this comment.
I think the usage of """ notice is wrong (I know the sop in confluence might be as well), but the use of the """ will introduce some issue if ever we generate some documentation automatically. Best is to just set his text with inline comments #
sanjay-boddu
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.ebi.ac.uk/panda/jira/browse/EA-891
This is a first step towards using a mongoengine ODM throughout Thoas. I'm planning to incrementally update the feature branch
feature/mongoengineand merge that in tomainonce we're happy with the ODM as a whole.Testing
pytest .andpylint.I ran the loading script on just plasmodium_falciparum, results are at graphql_220311141057_7f1f175. I tested on my mac that the Thoas server can read from this collection.