Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Index From AIF-HH & IU-HH #2545

Merged
merged 12 commits into from
Jan 30, 2025
Merged

Remove Index From AIF-HH & IU-HH #2545

merged 12 commits into from
Jan 30, 2025

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Jan 22, 2025

Description

This PR handles stripping the data from the index files for AIF-HH and IU-HH measures and then moving it all to the data.ts files.

In the end, I decided not to refactor the OMS component as I remembered how scary that code is. Instead I removed the IUHHPerformanceMeasureArray and AIFHHPerformanceMeasureArray, props and have them be set as variables in the component.
Screenshot 2025-01-22 at 3 26 34 PM

For more in-depth information of what stripping the index looks like, refer to this PR.

Related ticket(s)


How to test

Deploy Link: https://d38wunf9abjl4v.cloudfront.net/

  1. Sign into QMR, any user with health homes (i.e. [email protected])
  2. Add a Health Home Core Set
  3. Fill out AIF-HH, validate. Reload the page to make sure the data is still there
  4. Do the same for IU-HH
  5. Optional: Check the previous years to make sure the pages load and save.

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@ailZhou ailZhou marked this pull request as ready for review January 27, 2025 20:32
@ailZhou ailZhou added the ready for review Ready for all the reviews! label Jan 27, 2025
Copy link
Contributor

@rocio-desantiago rocio-desantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 2022 year and those measures are saving and data persists after refreshing.

Copy link
Contributor

@ajaitasaini ajaitasaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One tiny nit.

@@ -29,5 +29,6 @@ export interface MeasureTemplateData {
custom?: customData;
opm?: {
excludeOptions?: string[];
componentFlag?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the existing type definition that restricts this to "DEFAULT" | "AIF" | "IU" | "PCR"

Suggested change
componentFlag?: string;
componentFlag?: ComponentFlagType;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to do this as a tag along in a separate PR since it's small

@ailZhou ailZhou merged commit 0121d6f into master Jan 30, 2025
22 checks passed
@ailZhou ailZhou deleted the aif-iu-chunk branch January 30, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants