-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Index From AIF-HH & IU-HH #2545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested 2022 year and those measures are saving and data persists after refreshing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One tiny nit.
@@ -29,5 +29,6 @@ export interface MeasureTemplateData { | |||
custom?: customData; | |||
opm?: { | |||
excludeOptions?: string[]; | |||
componentFlag?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the existing type definition that restricts this to "DEFAULT" | "AIF" | "IU" | "PCR"
componentFlag?: string; | |
componentFlag?: ComponentFlagType; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to do this as a tag along in a separate PR since it's small
Description
This PR handles stripping the data from the index files for AIF-HH and IU-HH measures and then moving it all to the data.ts files.
In the end, I decided not to refactor the OMS component as I remembered how scary that code is. Instead I removed the IUHHPerformanceMeasureArray and AIFHHPerformanceMeasureArray, props and have them be set as variables in the component.
For more in-depth information of what stripping the index looks like, refer to this PR.
Related ticket(s)
How to test
Deploy Link: https://d38wunf9abjl4v.cloudfront.net/
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod