Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CDK DefaultStackSynthesizer from secrets manager to CDK code #15056

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Move CDK DefaultStackSynthesizer from secrets manager to CDK code #15056

merged 3 commits into from
Feb 11, 2025

Conversation

JonHolman
Copy link
Contributor

Description

Move CDK DefaultStackSynthesizer from secrets manager to CDK code

Related ticket(s)

CMDCT-4330

How to test

Notes

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

peoplespete
peoplespete approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@peoplespete peoplespete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, once you're satisfied

@JonHolman JonHolman merged commit dc35ad3 into jon-cdk Feb 11, 2025
12 checks passed
@JonHolman JonHolman deleted the cmdct-4330 branch February 11, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peoplespete peoplespete peoplespete approved these changes

@BearHanded BearHanded Awaiting requested review from BearHanded BearHanded is a code owner

@braxex braxex Awaiting requested review from braxex braxex is a code owner

@jessabean jessabean Awaiting requested review from jessabean jessabean is a code owner

@benmartin-coforma benmartin-coforma Awaiting requested review from benmartin-coforma benmartin-coforma is a code owner

Assignees

@JonHolman JonHolman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonHolman @peoplespete