Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session timeout adjustments - try to address sleep behavior #2786

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Sep 26, 2024

Summary

Related to #2719 we know we have an issue where when the computer is asleep, the idle timer won't fire (this is an open issue on the repository). We handle this by hitting refreshSession as soon as computer is active acgain, then forcing logout.

Current state: The logout is happening correctly but the timeout banner is not appearing on the landing page in deployed environments when the feature flag is set to 30 (it seems to work when feature flag is set to 2 minutes - which is what we were testing with before). It does logout, just looks like a normal logout and we want a banner there.

Expected state: The logout still happens correctly and the timeout banner also appears on landing page after computer sleep.

Other fixes: Also fixed the signout bug with this PR, when you manually click singout, no banner should show

Related issues

https://jiraent.cms.gov/browse/MCR-3860

Screenshots

Test cases covered

No new tests.

QA guidance

  • Do NOT use feature flags to adjust expiration time, let it stay the default.
  • Let your session idle more than 45 minutes (amount of time where when you come back, cognito should force logout and refreshSession will fail, earlier than the refreshSession may work because cognito still has credentials)

Copy link
Contributor

@JasonLin0991 JasonLin0991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Works for me. Left my computer go inactive for 45min and came back from the screen saver to Session timeout banner.

There are a bunch of code formatting issues. Not sure if something is going on.

haworku and others added 2 commits October 1, 2024 09:34
Weird styling issues getting through

Co-authored-by: Jason Lin <[email protected]>
@haworku haworku merged commit 6913a66 into main Oct 1, 2024
28 checks passed
@haworku haworku deleted the session-time-adjust-sleep-behavior branch October 1, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants