Skip to content

Commit

Permalink
Re-enable noConfusingVoidType and noVoidTypeReturn Biome rules (compi…
Browse files Browse the repository at this point in the history
…ler-explorer#7372)

Re-enables these rules and fixes the one spot it was applicable. Infact,
noConfusingVoidType had zero matches (because they were fixed in compiler-explorer#7080)
  • Loading branch information
junlarsen authored Feb 10, 2025
1 parent df522e9 commit be1e197
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 1 addition & 3 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
"noControlCharactersInRegex": "off",
"noShadowRestrictedNames": "off",
"noFallthroughSwitchClause": "off",
"noDoubleEquals": "off",
"noConfusingVoidType": "off"
"noDoubleEquals": "off"
},
"style": {
"noParameterAssign": "off",
Expand All @@ -33,7 +32,6 @@
"useTemplate": "off"
},
"correctness": {
"noVoidTypeReturn": "off",
"noUnsafeOptionalChaining": "off"
},
"performance": {
Expand Down
3 changes: 2 additions & 1 deletion static/panes/editor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1152,10 +1152,11 @@ export class Editor extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Edit
const lang = this.currentLanguage;

if (!Object.prototype.hasOwnProperty.call(lang, 'formatter')) {
return this.alertSystem.notify('This language does not support in-editor formatting', {
this.alertSystem.notify('This language does not support in-editor formatting', {
group: 'formatting',
alertClass: 'notification-error',
});
return;
}

$.ajax({
Expand Down

0 comments on commit be1e197

Please sign in to comment.