Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug where the wrong param was passed into columnonehotencoder #165

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

perib
Copy link
Collaborator

@perib perib commented Jan 3, 2025

[please review the Contribution Guidelines prior to submitting your pull request. go ahead and delete this line if you've already reviewed said guidelines.]

What does this PR do?

Issue #163 identified a bug where the wrong parameter was being passed into ColumnOneHotEncoder when using the default fixed preprocessing steps. This removes the wrong parameter and replaces it with the original parameter before the bug was introduced.

Where should the reviewer start?

How should this PR be tested?

run TPOTEstimator and TPOTEsimatorSteadyState with the fixed preprocessing pipeline on pandas df that includes categorical columns.

Any background context you want to provide?

Issue #163

What are the relevant issues?

Issue #163

Questions:

  • Do the docs need to be updated?
    no
  • Does this PR add new (Python) dependencies?
    no

@nickotto nickotto merged commit a19a950 into EpistasisLab:main Jan 6, 2025
1 check failed
@perib perib deleted the columnonehotencoder_fix branch January 6, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants