Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sdk-test-data as a submodule #22

Merged
merged 1 commit into from
Aug 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ jobs:
toolchain:
- stable
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- run: npm ci
- run: make test-data
- run: rustup update ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }}
- run: cargo build --verbose
- run: cargo test --verbose
Expand All @@ -37,6 +38,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
submodules: true

- name: Set up Ruby & Rust
uses: oxidize-rb/actions/setup-ruby-and-rust@v1
Expand All @@ -47,7 +50,6 @@ jobs:
rubygems: '3.5.11'

- run: npm ci
- run: make test-data

- name: Check Cargo.lock
# Ensure that Cargo.lock matches Cargo.toml
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/msrv.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ jobs:
- stable

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- uses: actions/cache@v2
with:
path: |
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ jobs:
runs-on: ubuntu-latest
if: ${{ startsWith(github.ref_name, 'eppo_core@') || startsWith(github.ref_name, 'rust-sdk@') }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- uses: actions/setup-node@v3
with:
node-version: '20'
- run: npm ci
- run: make test-data
- name: Install Rust toolchain
run: rustup update stable && rustup default stable
- name: Build Release
Expand All @@ -59,7 +60,9 @@ jobs:
runs-on: ubuntu-latest
if: ${{ startsWith(github.ref_name, 'ruby-sdk@') }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- uses: actions/setup-node@v3
with:
node-version: '20'
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@
# MSVC Windows builds of rustc generate these, which store debugging information
*.pdb

/sdk-test-data/
node_modules
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "sdk-test-data"]
path = sdk-test-data
url = https://github.com/Eppo-exp/sdk-test-data.git
13 changes: 0 additions & 13 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,6 @@ help: Makefile
@echo "usage: make <target>"
@sed -n 's/^##//p' $<

## test-data
testDataDir := sdk-test-data
branchName := main
githubRepoLink := https://github.com/Eppo-exp/sdk-test-data.git
.PHONY: test-data
test-data:
rm -rf ${testDataDir}
git clone -b ${branchName} --depth 1 --single-branch ${githubRepoLink} ${testDataDir}

${testDataDir}:
rm -rf ${testDataDir}
git clone -b ${branchName} --depth 1 --single-branch ${githubRepoLink} ${testDataDir}

.PHONY: test
test: ${testDataDir}
npm test
1 change: 1 addition & 0 deletions sdk-test-data
Submodule sdk-test-data added at 830f20
Loading