FF-2465 make orderPosition 1-indexed to match UI

Eppo-exp · Jun 26, 2024 · ebed05a · ebed05a
1 parent b1cf4a8
commit ebed05a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/evaluator.ts b/src/evaluator.ts
@@ -62,7 +62,7 @@ export class Evaluator {
         unmatchedAllocations.push({
           key: allocation.key,
           allocationEvaluationCode: code,
-          orderPosition: i,
+          orderPosition: i + 1,
         });
       };
 

diff --git a/src/flag-evaluation-details-builder.ts b/src/flag-evaluation-details-builder.ts
@@ -85,7 +85,7 @@ export class FlagEvaluationDetailsBuilder {
   };
 
   setMatch = (
-    orderPosition: number,
+    indexPosition: number,
     variation: Variation,
     allocation: Allocation,
     matchedRule: Rule | null,
@@ -103,16 +103,17 @@ export class FlagEvaluationDetailsBuilder {
     this.matchedAllocation = {
       key: allocation.key,
       allocationEvaluationCode: AllocationEvaluationCode.MATCH,
-      orderPosition,
+      orderPosition: indexPosition + 1, // orderPosition is 1-indexed to match UI
     };
     this.unmatchedAllocations = unmatchedAllocations;
-    const unevaluatedStartIndex = orderPosition + 1;
+    const unevaluatedStartIndex = indexPosition + 1;
+    const unevaluatedStartOrderPosition = unevaluatedStartIndex + 1; // orderPosition is 1-indexed to match UI
     this.unevaluatedAllocations = this.allocations.slice(unevaluatedStartIndex).map(
       (allocation, i) =>
         ({
           key: allocation.key,
           allocationEvaluationCode: AllocationEvaluationCode.UNEVALUATED,
-          orderPosition: unevaluatedStartIndex + i,
+          orderPosition: unevaluatedStartOrderPosition + i,
         } as AllocationEvaluation),
     );
     return this;