fix: remove unnecessary precomputed constructor error logs #229
+88
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typotter
approved these changes
Mar 4, 2025
sameerank
deleted the
sameeran/remove-unnecessary-precomputed-constructor-error-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
There is a place in
EppoPrecomputedJSClient's implementation where we want to initialize the instance with an empty store.https://github.com/Eppo-exp/js-client-sdk/blob/5b317dab2cda07abb8aa259a14e7f88ac1dfc963/src/index.ts#L680-L688
This results in the following two errors getting logged
Even if the client isn't even using the precomputed client, since we are initializing it automatically to ensure that
getPrecomputedInstancealways returns an instance.Description
The change here allows
EppoPrecomputedClient's initialization with an empty store without a salt and without the store being set to initialized.How has this been tested?
Some unit tests that reproduce what is happening in the
js-client-sdk