This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
FF-3106 fix: ContextAttributes.from_dict() should not treat bool as numeric
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤯 I thought this kind of stuff only happens in JS 🤣 |
rasendubi
force-pushed
the
ff-3106-contextattributes_fromdict_bool_as_numeric
branch
from
25e5f8d to
591e1cf
Compare
rasendubi
commented
Aug 29, 2024
| @@ -1,4 +1,4 @@ | |||
| # Note to developers: When ready to bump to 4.0, please change | |||
| # the `POLL_INTERVAL_SECONDS` constant in `eppo_client/constants.py` | |||
| # to 30 seconds to match the behavior of the other server SDKs. | |||
| __version__ = "3.5.3" | |||
| __version__ = "3.5.4" | |||
There was a problem hiding this comment.
Bumped the version as 3.5.3 was just released
rasendubi
deleted the
ff-3106-contextattributes_fromdict_bool_as_numeric
branch
aarsilv
reviewed
Aug 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: https://linear.app/eppo/issue/FF-3106/%5Bpython%5D-contextattributesfrom-dict-adds-bool-attributes-to-both
Motivation and Context
The added test case was failing because bool was added to both categorical (as
"true") and numeric (as1.0) attributes. This happened becauseboolis a subtype ofintin Python, soisinstance(True, int) == True.Description
And an explicit check that attribute is not
boolin categorical attributes filter.How has this been tested?
Added a test case.