Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

FF-3150 feat: allow passing initial_configuration #70

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

rasendubi
Copy link
Collaborator

@rasendubi rasendubi commented Sep 4, 2024


labels: mergeable

Fixes: https://linear.app/eppo/issue/FF-3150/%5Bpython%5D-allow-python-sdk-to-be-bootstrapped-from-configuration

Motivation and Context

Description

  • Add Configuration class that can be initialized from a JSON-serialized flags configuration: Configuration(flags_configuration="{…}")
  • Add initial_configuration: Optional[Configuration] field to Config which initializes configuration store with this value.
  • Make poll_interval_seconds Optional[int] (allow None), which disables polling

How has this been tested?

initial_configuration=Configuration(flags_configuration='{"flags":{}}'),
)
)
assert client.is_initialized()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - elegant.

@rasendubi rasendubi force-pushed the FF-3150-feat-initial-configuration branch from 4611103 to f29fe7a Compare September 5, 2024 11:49
@rasendubi rasendubi changed the title WIP FF-3150 feat: allow passing initial_configuration FF-3150 feat: allow passing initial_configuration Sep 5, 2024
@leoromanovsky leoromanovsky merged commit 6840c33 into main Sep 5, 2024
4 checks passed
@leoromanovsky leoromanovsky deleted the FF-3150-feat-initial-configuration branch September 5, 2024 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants