quality: parameterize sdk and test data branches #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typotter
commented
Nov 26, 2024
|
|
||
| workflow_dispatch: | ||
|
|
||
| workflow_call: |
There was a problem hiding this comment.
Allows specifying branches when used as a reusable workflow
typotter
commented
Nov 26, 2024
| branches: [main] | ||
| branches: [main, tp/**] | ||
|
|
||
| workflow_dispatch: |
There was a problem hiding this comment.
Used to allow dispatching via web API (remotely triggered test run when changes are made to sdk-test-data)
| @@ -21,6 +37,8 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| repository: Eppo-exp/sdk-common-jdk | |||
There was a problem hiding this comment.
explicitly specify the repo and ref otherwise, when run as a reusable workflow in another repo, this would not checkout the java-common SDK as required
| @@ -40,7 +40,7 @@ test-data: | |||
| mkdir -p ${tempDir} | |||
| git clone -b ${branchName} --depth 1 --single-branch ${githubRepoLink} ${gitDataDir} | |||
| cp -r ${gitDataDir}/ufc ${testDataDir} | |||
| rm ${testDataDir}/ufc/bandit-tests/*.dynamic-typing.json | |||
| rm -f ${testDataDir}/ufc/bandit-tests/*.dynamic-typing.json || true | |||
There was a problem hiding this comment.
bumped into this failing when I was doing some local testing that involved temporarily deleting most of the test data/cases. We shouldn't bump over this in any real scenario but no need to have this fail at any rate
| "https://us-central1-eppo-qa.cloudfunctions.net/serveGitHubRacTestFile"; | ||
| private static final String TEST_HOST = |
There was a problem hiding this comment.
aarsilv
approved these changes
Dec 3, 2024
| @@ -32,4 +50,4 @@ jobs: | |||
| gpg-passphrase: ${{ secrets.GPG_PASSPHRASE }} | |||
|
|
|||
| - name: Run tests | |||
| run: make test | |||
| run: make test branchName=${TEST_DATA_BRANCH} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes FF-3560 towards FF-3085
👯♂️ Related PRs
Motivation
Changes are often made to the sdk-test-data repository to capture new behaviours, bugs and edge cases. When these changes are pushed to
main, the SDKs are cloned locally (locally to the github action running) and their respective tests are run. These tests are set up and run by copies of the SDK test workflows - see sdk-test-data workflow. There are a number of limitations to this setup:sdk-test-dataDescription of Changes
This change
🚀 - Each SDK's testing workflow is enhanced into a reusable workflow, exposing parameters for SDK branch and the sdk-test-data branch to use in testing.
External to this Change
sdk-test-data has two testing workflows.