FF-2498 fix more floating point issues (#33)

Eppo-exp · Jun 25, 2024 · 33d4d81 · 33d4d81
1 parent f4c6db1
commit 33d4d81
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 11 deletions.
diff --git a/ufc/tests/test-case-numeric-flag.json b/ufc/tests/test-case-numeric-flag.json
@@ -1,7 +1,7 @@
 {
   "flag": "numeric_flag",
   "variationType": "NUMERIC",
-  "defaultValue": 0,
+  "defaultValue": 0.0,
   "subjects": [
     {
       "subjectKey": "alice",

diff --git a/ufc/tests/test-flag-that-does-not-exist.json b/ufc/tests/test-flag-that-does-not-exist.json
@@ -1,17 +1,17 @@
 {
   "flag": "flag-that-does-not-exist",
   "variationType": "NUMERIC",
-  "defaultValue": 0,
+  "defaultValue": 0.0,
   "subjects": [
     {
       "subjectKey": "alice",
       "subjectAttributes": {
         "email": "[email protected]",
         "country": "US"
       },
-      "assignment": 0,
+      "assignment": 0.0,
       "assignmentDetails": {
-        "value": 0,
+        "value": 0.0,
         "flagEvaluationCode": "FLAG_UNRECOGNIZED_OR_DISABLED",
         "flagEvaluationDescription": "Unrecognized or disabled flag: flag-that-does-not-exist",
         "variationKey": null,
@@ -28,9 +28,9 @@
         "email": "[email protected]",
         "country": "Canada"
       },
-      "assignment": 0,
+      "assignment": 0.0,
       "assignmentDetails": {
-        "value": 0,
+        "value": 0.0,
         "flagEvaluationCode": "FLAG_UNRECOGNIZED_OR_DISABLED",
         "flagEvaluationDescription": "Unrecognized or disabled flag: flag-that-does-not-exist",
         "variationKey": null,
@@ -46,9 +46,9 @@
       "subjectAttributes": {
         "age": 50
       },
-      "assignment": 0,
+      "assignment": 0.0,
       "assignmentDetails": {
-        "value": 0,
+        "value": 0.0,
         "flagEvaluationCode": "FLAG_UNRECOGNIZED_OR_DISABLED",
         "flagEvaluationDescription": "Unrecognized or disabled flag: flag-that-does-not-exist",
         "variationKey": null,

diff --git a/ufc/tests/test-json-config-flag.json b/ufc/tests/test-json-config-flag.json
@@ -23,7 +23,11 @@
         "flagEvaluationCode": "MATCH",
         "flagEvaluationDescription": "alice belongs to the range of traffic assigned to \"one\" defined in allocation \"50/50 split\".",
         "variationKey": "one",
-        "variationValue": "{ \"integer\": 1, \"string\": \"one\", \"float\": 1.0 }",
+        "variationValue": {
+          "integer": 1,
+          "string": "one",
+          "float": 1.0
+        },
         "matchedRule": null,
         "matchedAllocation": {
           "key": "50/50 split",
@@ -54,7 +58,11 @@
         "flagEvaluationCode": "MATCH",
         "flagEvaluationDescription": "bob belongs to the range of traffic assigned to \"two\" defined in allocation \"50/50 split\".",
         "variationKey": "two",
-        "variationValue": "{ \"integer\": 2, \"string\": \"two\", \"float\": 2.0 }",
+        "variationValue": {
+          "integer": 2,
+          "string": "two",
+          "float": 2.0
+        },
         "matchedRule": null,
         "matchedAllocation": {
           "key": "50/50 split",
@@ -84,7 +92,11 @@
         "flagEvaluationCode": "MATCH",
         "flagEvaluationDescription": "charlie belongs to the range of traffic assigned to \"two\" defined in allocation \"50/50 split\".",
         "variationKey": "two",
-        "variationValue": "{ \"integer\": 2, \"string\": \"two\", \"float\": 2.0 }",
+        "variationValue": {
+          "integer": 2,
+          "string": "two",
+          "float": 2.0
+        },
         "matchedRule": null,
         "matchedAllocation": {
           "key": "50/50 split",