fix: preserve allocation evaluation details when ASSIGNMENT_ERROR

ASSIGNMENT_ERROR later in the evaluation process should not revert the previously-done evaluation and definitely should not list unmatched/matched allocations as "unevaluated."
Eppo-exp · Jul 29, 2024 · 364ea92 · 364ea92
1 parent 439c7a5
commit 364ea92
Showing 1 changed file with 23 additions and 25 deletions.
diff --git a/ufc/tests/test-case-invalid-value-flag.json b/ufc/tests/test-case-invalid-value-flag.json
@@ -16,23 +16,22 @@
         "flagEvaluationDescription": "Variation (pi) is configured for type INTEGER, but is set to incompatible value (3.1415926)",
         "banditKey": null,
         "banditAction": null,
-        "variationKey": null,
-        "variationValue": null,
+        "variationKey": "pi",
+        "variationValue": 3.1415926,
         "matchedRule": null,
-        "matchedAllocation": null,
-        "unmatchedAllocations": [],
-        "unevaluatedAllocations": [
+        "matchedAllocation": {
+          "key": "invalid",
+          "allocationEvaluationCode": "MATCH",
+          "orderPosition": 2
+        },
+        "unmatchedAllocations": [
           {
             "key": "valid",
-            "allocationEvaluationCode": "UNEVALUATED",
+            "allocationEvaluationCode": "FAILING_RULE",
             "orderPosition": 1
-          },
-          {
-            "key": "invalid",
-            "allocationEvaluationCode": "UNEVALUATED",
-            "orderPosition": 2
           }
-        ]
+        ],
+        "unevaluatedAllocations": []
       }
     },
     {
@@ -88,24 +87,23 @@
         "flagEvaluationDescription": "Variation (pi) is configured for type INTEGER, but is set to incompatible value (3.1415926)",
         "banditKey": null,
         "banditAction": null,
-        "variationKey": null,
-        "variationValue": null,
+        "variationKey": "pi",
+        "variationValue": 3.1415926,
         "matchedRule": null,
-        "matchedAllocation": null,
-        "unmatchedAllocations": [],
-        "unevaluatedAllocations": [
+        "matchedAllocation": {
+          "key": "invalid",
+          "allocationEvaluationCode": "MATCH",
+          "orderPosition": 2
+        },
+        "unmatchedAllocations": [
           {
             "key": "valid",
-            "allocationEvaluationCode": "UNEVALUATED",
+            "allocationEvaluationCode": "FAILING_RULE",
             "orderPosition": 1
-          },
-          {
-            "key": "invalid",
-            "allocationEvaluationCode": "UNEVALUATED",
-            "orderPosition": 2
           }
-        ]
+        ],
+        "unevaluatedAllocations": []
       }
     }
   ]
-}
+}