Selki/node sdk relay features/bandits handling #104
Conversation
There was a problem hiding this comment.
Quick comment - this needs to be integrated into github actions:
https://github.com/Eppo-exp/sdk-test-data/blob/main/.github/workflows/test-sdk-packages.yml#L10
On its own it does not produce any meaningful testing. After integrating the github actions will compile the code from source, start the server and collect test results. Are you wanting to add that in this PR or a stacked one? I prefer this PR as it would make reviewing the code in it easier since we can see whether it passes.
@leoromanovsky I wanted to do a stacked one to avoid bigger PR but now that you mentioned that It does makes sense to keep it in one PR. I will tag you once more once I add everything regarding workflows. |
* test case for special characters * update obfuscated config * update names in description * include unevaluated allocation * update cyrillic language example * fix reason
| @@ -0,0 +1,99 @@ | |||
| <p align="center"> | |||
There was a problem hiding this comment.
Are there any notes or commands you can write here for the next person to work on this code?
There was a problem hiding this comment.
I've changed this file a bit. It will grow more once I finish build-and-run script
ufc/flags-v1.json
Outdated
| @@ -1186,6 +1186,104 @@ | |||
| } | |||
| ], | |||
| "totalShards": 10000 | |||
| }, | |||
There was a problem hiding this comment.
I don't understand why it shows in diff, but that's something that is already in main branch. It probably was added when I rebased main onto feature branch
| @@ -0,0 +1,143 @@ | |||
| { | |||
* inital app from create-expo-app * add Eppo SDK; traditional and precomputed client * Eppo Client provider and basic flag/bandit display
…ndits-handling' into selki/node-sdk-relay-features/bandits-handling
| @@ -0,0 +1,99 @@ | |||
| <p align="center"> | |||
| @@ -0,0 +1,12 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
can merge and as and we'll iterate on the script.
| @@ -0,0 +1,8 @@ | |||
| // https://docs.expo.dev/guides/using-eslint/ | |||
There was a problem hiding this comment.
weird merge artifact? the react-native-sdk-relay is already in the repo.
There was a problem hiding this comment.
Yeah I tried merging main into feature branch, but the artifacts didnt go away.
| @@ -33,7 +33,7 @@ jobs: | |||
| test_data_branch: ${{ github.head_ref || github.ref_name }} | |||
| sdk_branch: main | |||
|
|
|||
| test-node-client-sdk: | |||
| test-js-client-sdk: | |||
maya-the-mango
deleted the
selki/node-sdk-relay-features/bandits-handling
branch
No description provided.