-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added test cases for flags with empty string value #108
added test cases for flags with empty string value #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typing and object property errors in here. Look at test-case-new-user-onboarding-flag.json
for an example string-valued flag test file.
Also, you can try this out locally by checking out the common javascript SDK and then dropping this file in the test data directory so it is run. That is the development pattern I use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through this one with me.
You will need to rebase with main before the js-client tests will run and pass properly (to pick up my workflow fix)
I reran the test suites but the js-client seems to be stuck using the test workflow from before my fix. If you push changes to your branch, it should reload the workflow files from the remote repositories
I dug into the multiplatform test failing and found an issue in the test file that I suppose only that SDK is checking. I made a suggested change in the test file with the expected structure for you.
Thanks again! Please make sure the test suites are all passing before merging.
} | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:add newline please.
…-for-ff-with-empty-strings-as
Co-authored-by: Tyler Potter <[email protected]>
I tracked down the cause of react-native and js-client tests failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating! Assuming these pass when you drop them into an SDK and run all the tests cases, I'd say we are good 🚀
Loosen validation to allow empty string in string-valued flag variations was added in this ticker https://linear.app/eppo/issue/FF-3794/loosen-validation-to-allow-empty-string-in-string-valued-flag