Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF-2509 CI job to validate test data #34

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

greghuels
Copy link
Contributor

@greghuels greghuels commented Jun 25, 2024

This runs a new yarn validate:tests script to validate test data. With assignmentDetails now existing, it will be easy to make a change to assignment and forget to update the values in assignmentDetails, so this job prevents against that situation.

@greghuels greghuels force-pushed the greg/FF-2509/verify-test-data branch from 7578593 to a7d6d81 Compare June 25, 2024 14:26
Copy link
Member

@felipecsl felipecsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! only feedback would be around using jest for a more standard setup here that's easier to expand, but not blocking on this

@greghuels
Copy link
Contributor Author

nice work! only feedback would be around using jest for a more standard setup here that's easier to expand, but not blocking on this

Thanks for the feedback! I'll update with Jest -- I think you're right.

@greghuels
Copy link
Contributor Author

@felipecsl

Screenshot 2024-06-25 at 11 56 25 AM

@greghuels greghuels merged commit e79b6e9 into main Jun 25, 2024
1 check passed
@felipecsl felipecsl deleted the greg/FF-2509/verify-test-data branch June 25, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants