Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF-2526 include environment and allocation.name in UFC response #38

Merged
merged 4 commits into from
Jul 1, 2024
Merged

FF-2526 include environment and allocation.name in UFC response #38

merged 4 commits into from
Jul 1, 2024

Conversation

greghuels
Copy link
Contributor

@greghuels greghuels commented Jun 28, 2024 •
edited
Loading

Includes environment and allocation.name in UFC test data

@greghuels greghuels changed the title FF-2526 include environment in UFC response FF-2526 include environment and allocation.name in UFC response Jun 28, 2024
@greghuels greghuels force-pushed the greg/FF-2526/ufc-environment branch from ec434ad to f16f031 Compare June 28, 2024 16:18
@greghuels greghuels requested review from aarsilv and sameerank June 28, 2024 16:21
aarsilv
aarsilv approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sense you did some cool regex foo here 😅

ufc/bandit-flags-v1.json Outdated
@@ -1,5 +1,6 @@
{
"createdAt": "2024-04-17T19:40:53.716Z",
"environment": "Test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@greghuels
Copy link
Contributor Author

I sense you did some cool regex foo here 😅

Definitely didn't update these one at a time. 😆

@greghuels greghuels merged commit 60e1a5f into main Jul 1, 2024
1 check passed
@greghuels greghuels deleted the greg/FF-2526/ufc-environment branch July 1, 2024 14:08
@greghuels greghuels mentioned this pull request Jul 1, 2024
Merged
greghuels added a commit that referenced this pull request Jul 1, 2024
@greghuels
Revert "FF-2526 include environment and allocation.name in UFC respon…
ce933e1 
…se (#38)"

This reverts commit 60e1a5f.
greghuels added a commit that referenced this pull request Jul 1, 2024
@greghuels
Revert "FF-2526 fix tests for assignmentDetails object (#40)" (#41)
93e05ab 
* Revert "FF-2526 fix tests for assignmentDetails object (#40)"

This reverts commit e169514.

* Revert "FF-2526 include environment and allocation.name in UFC response (#38)"

This reverts commit 60e1a5f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarsilv aarsilv aarsilv approved these changes

@sameerank sameerank sameerank approved these changes

Assignees

@greghuels greghuels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greghuels @aarsilv @sameerank