Fix whitelisting of non-existing ks/table #14
Merged
+160
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 58
💛 - Coveralls |
emolsson
reviewed
Sep 25, 2018
src/main/java/com/ericsson/bss/cassandra/ecaudit/AuditEntryBuilderFactory.java
Outdated
Show resolved
Hide resolved
| @@ -531,6 +525,45 @@ public void testFailedStatementsAreLogged() | |||
| .containsAll(expectedAttemptsAndFails(statements)); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
I might be missing it, but I'd like to see a test case for a failed batch statement which is not whitelisted.
emolsson
reviewed
Sep 26, 2018
| @@ -78,7 +79,7 @@ public Builder createEntryBuilder(String operation, ClientState state) | |||
| CQLStatement statement = QueryProcessor.getStatement(operation, state).statement; | |||
| return createEntryBuilder(statement); | |||
| } | |||
| catch (KeyspaceNotDefinedException e) | |||
| catch (InvalidRequestException e) | |||
There was a problem hiding this comment.
If we throw an exception from within the catch clause here we would throw it through the stack. Should we have "catch (RunTimeException)" outside of this try/catch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.