Fix ordering of images in video sequence #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishs17
reviewed
Jan 22, 2020
Comment on lines
+72
to
+80
| images_info = [(x.file.url, x.width, x.height) for x in files] | ||
|
|
||
| def get_num(im_info): | ||
| url = im_info[0] | ||
| name = os.path.split(url)[-1] | ||
| num = os.path.splitext(name)[0] | ||
| return int(num) | ||
|
|
||
| images_info = sorted(images_info, key=get_num) |
There was a problem hiding this comment.
The solution might fail when some one uploads set of images with names having character and numbers.
e.g. : image_0001.jpg, image_002.jpg etc.
In such a case, int(image_001) would give a ValueError: invalid literal for int( )
There was a problem hiding this comment.
I needed this fix for video, so some modification like single if-else may be needed to work with images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2