Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for Docker and image downloading #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stollcri
Copy link

@stollcri stollcri commented May 6, 2020

  • Fix issue preventing docker-compose build from working (on MacOS Catalina)
  • Fix issue downloading large image zip files (stream the download)

@manishs17
Copy link

Are the changes compatible with older MacOS versions ?

@stollcri
Copy link
Author

stollcri commented May 8, 2020

Yes, they should be, but I can only test on the most current version

@manishs17
Copy link

okay, I would test on some of them before merging. Thanks for the contribution.

@claverru
Copy link

Helo @stollcri , @manishs17,

I've had problems building the image via Docker with:

FileNotFoundError: [Errno 2] No such file or directory: 'llvm-config'
[...]
ERROR: Failed building wheel for llvmlite

It was solved by changing python:3-5-slim to python:3.6-slim in the Dockerfile, as it's stated in installation instructions (Python 3.6).

I don't know if this is related, but could work.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants