Build error with clang #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the error output that you see without your patch? |
|
You can find the full log in the issue: ( I wanted to paste the issure number here, but missed.) |
|
And this one? :) |
|
I don't like removing -Werror. I would prefer something more specific if possible. Is it? |
|
It isn't trivial to fix it without removing -Werror, I explained it in my first comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first idea was to set -Wno-parentheses-equality CFLAGS. in gst/videorepair/Makefile.am,
but it doesn't work, because the parent Makefile adds -Wall to CFLAGS which comes after
libgstvideorepair_la_CFLAGS and overrides the -Wno-parentheses-equality option.