Separate delete from delete_counter #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using delete for two different things - deleting records and deleting keys from the counter table - was causing problems like: ErlyORM#135 This commit introduces a delete_counter that only deletes keys from the counter. The delete function only deletes records.
|
As part of commit you updated pgsql adapter. But other connectors are not updated yet and I will postpone merge of your PR till we prepare changes in other connectors too. |
|
I think we should figure out the general direction first. I'm also not 100% convinced of this code; the counters are kind of strange. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using delete for two different things - deleting records and deleting
keys from the counter table - was causing problems like:
#135
This commit introduces a delete_counter that only deletes keys from
the counter. The delete function only deletes records.
Fixes #135