Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTM Individual review #4

Open
EshikaP1 opened this issue Mar 1, 2024 · 3 comments
Open

NTM Individual review #4

EshikaP1 opened this issue Mar 1, 2024 · 3 comments

Comments

@EshikaP1
Copy link
Owner

EshikaP1 commented Mar 1, 2024

Here is the link to my video: https://drive.google.com/file/d/1w8RAuHLlzhRwu5xpgPCaR0BcOM33XAmf/view?usp=sharing
Here is the link to my individual issue: https://eshikap1.github.io/Student2//2024/02/26/NTM_REVIEW.html

Key Commits:
-Final backend code for drink: EshikaP1/2back@f9743ce
-Login commit: EshikaP1/2front@46bdbc3
-Another login commit: EshikaP1/2front@d78d3ea
-Backend User code final: EshikaP1/2back@2ae0348
-Deployment: EshikaP1/2back@c0c029c
image

@Nupurbb
Copy link

Nupurbb commented Mar 1, 2024

Hi, you did a great job and I loved seeing your video!
Here are some grows and glows:
Glows:
The database for your drinks on the backend
The delete function on the page
being able to add new drinks
the calories apperaing for every drink after an input
Glows:
Adding more css changes to te=he background color
Adding images of some drinks to make the page pop more
adding an interactive drink game

Overall grear job, .98/1!!

@cliang1
Copy link

cliang1 commented Mar 1, 2024

Great job with the styling, the theme was consistent and engaging. I liked how your data was concise, so it was easy to understand what was happening in the code. The demonstration adding and deleting drinks from the database was also very clear.

Glows:

  • The video clearly explained the functions of the code
  • functions all worked as expected
  • CSS and styling for the website overall was nice
  • Clear explanations of the College Board requirements on blog page
  • Great job with deployment
    Grows:
  • Could add information about the College Board requirements for the video
  • CSS styling for the page itself could be more consistent - making the buttons pink instead of green
  • Add Key Commits to the blog statement

Overall Grade: 0.98/1.0

@Aditi99b
Copy link

Aditi99b commented Mar 1, 2024

0.96/1

The website is well formed fulfills all Collegeboard requirements. Authentication is implemented correctly, looking at the code. I recommend showing a redirect to custom error page on the video to demonstrate the functionality of the login authentication, but otherwise not much to be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants