Skip to content

Commit

Permalink
[unity] Code and method signature cleanup (made ApplyAnimation and Af…
Browse files Browse the repository at this point in the history
…terAnimationApplied public virtual).
  • Loading branch information
HaraldCsaszar committed Nov 24, 2023
1 parent ba54db2 commit f029c1d
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -232,20 +232,23 @@ public void Update (float deltaTime) {
return;
UpdateAnimationStatus(deltaTime);

if (updateMode == UpdateMode.OnlyAnimationStatus) {
state.ApplyEventTimelinesOnly(skeleton, issueEvents: false);
if (updateMode == UpdateMode.OnlyAnimationStatus)
return;
}
ApplyAnimation();
}

protected void UpdateAnimationStatus (float deltaTime) {
deltaTime *= timeScale;
state.Update(deltaTime);
skeleton.Update(deltaTime);

if (updateMode == UpdateMode.OnlyAnimationStatus) {
state.ApplyEventTimelinesOnly(skeleton, issueEvents: false);
return;
}
}

protected void ApplyAnimation () {
public virtual void ApplyAnimation () {
if (_BeforeApply != null)
_BeforeApply(this);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,8 @@ public virtual void Update (float deltaTime) {
return;
UpdateAnimationStatus(deltaTime);

if (updateMode == UpdateMode.OnlyAnimationStatus) {
state.ApplyEventTimelinesOnly(skeleton, issueEvents: false);
if (updateMode == UpdateMode.OnlyAnimationStatus)
return;
}
ApplyAnimation();
}

Expand All @@ -382,9 +380,14 @@ protected void UpdateAnimationStatus (float deltaTime) {
deltaTime *= timeScale;
state.Update(deltaTime);
skeleton.Update(deltaTime);

if (updateMode == UpdateMode.OnlyAnimationStatus) {
state.ApplyEventTimelinesOnly(skeleton, issueEvents: false);
return;
}
}

protected void ApplyAnimation () {
public virtual void ApplyAnimation () {
if (BeforeApply != null)
BeforeApply(this);

Expand All @@ -396,7 +399,7 @@ protected void ApplyAnimation () {
AfterAnimationApplied();
}

public void AfterAnimationApplied () {
public virtual void AfterAnimationApplied () {
if (UpdateLocal != null)
UpdateLocal(this);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ protected void UpdateAnimation (float deltaTime) {
ApplyAnimation();
}

protected void ApplyAnimation () {
public virtual void ApplyAnimation () {
if (_BeforeApply != null)
_BeforeApply(this);

Expand All @@ -152,7 +152,7 @@ protected void ApplyAnimation () {
AfterAnimationApplied();
}

public void AfterAnimationApplied () {
public virtual void AfterAnimationApplied () {
if (_UpdateLocal != null)
_UpdateLocal(this);

Expand Down

0 comments on commit f029c1d

Please sign in to comment.