[New] Show device location using indoor positioning #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswebb09
changed the title
chriswebb09
commented
Jul 19, 2024
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
yo1995
reviewed
Jul 23, 2024
... device location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.swift
Outdated
Show resolved
Hide resolved
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show device location using indoor positioning/README.md
Outdated
Show resolved
Hide resolved
Shared/Samples/Show device location using indoor positioning/README.md
Outdated
Show resolved
Hide resolved
yo1995
reviewed
Aug 15, 2024
Shared/Samples/Show device location using indoor positioning/README.md
Outdated
Show resolved
Hide resolved
... device location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.swift
Outdated
Show resolved
Hide resolved
... device location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.swift
Outdated
Show resolved
Hide resolved
... device location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.swift
Outdated
Show resolved
Hide resolved
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
yo1995
reviewed
Aug 15, 2024
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
yo1995
requested review from
philium,
a team and
CalebRas
and removed request for
a team
philium
reviewed
Aug 19, 2024
...e location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.Model.swift
Outdated
Show resolved
Hide resolved
CalebRas
previously approved these changes
Aug 19, 2024
Shared/Samples/Show device location using indoor positioning/README.md
Outdated
Show resolved
Hide resolved
... device location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.swift
Show resolved
Hide resolved
... device location using indoor positioning/ShowDeviceLocationUsingIndoorPositioningView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Caleb Rasmussen <[email protected]>
CalebRas
approved these changes
Aug 19, 2024
philium
approved these changes
Aug 19, 2024
|
😁 |
|
Thank you all for the feedback. Chris, great job for pulling all the pieces together! |
yo1995
deleted the
chriswebb/New-ShowDeviceLocationUsingIndoorPositioning
branch
|
Thank you guys for getting it across the finish line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Show device location using indoor positioninginMapcategory.swift/issues/5653(internal test data in the issue)common-samples/pull/3939How To Test
Load map and wait for campus to load. You should see your location relative to the layout of the office.
Please note:
indoorPositioningDefinitionand the manualips_positioningcreation of the LDS should work, so make sure you test both condition branchesScreenshots