[Update] Bump version to Xcode 16 #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
changed the title
|
When the Swift Language Version is bumped to Swift 6.0, there are a few errors and warnings that pops up. Upon discussion with Phil R, I'll address these errors in this PR. |
yo1995
commented
Sep 23, 2024
Shared/Samples/Animate 3D graphic/Animate3DGraphicView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create and save KML file/CreateAndSaveKMLView.swift
Outdated
Show resolved
Hide resolved
...d/Samples/Show viewshed from geoelement in scene/ShowViewshedFromGeoelementInSceneView.swift
Outdated
Show resolved
Hide resolved
yo1995
changed the title
philium
reviewed
Sep 24, 2024
Shared/Samples/Animate 3D graphic/Animate3DGraphicView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create and save KML file/CreateAndSaveKMLView.swift
Outdated
Show resolved
Hide resolved
...d/Samples/Show viewshed from geoelement in scene/ShowViewshedFromGeoelementInSceneView.swift
Outdated
Show resolved
Hide resolved
Shared/Supporting Files/Extensions/Array+RawRepresentable.swift
Outdated
Show resolved
Hide resolved
yo1995
commented
Sep 25, 2024
Shared/Samples/Create and save KML file/CreateAndSaveKMLView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create mobile geodatabase/CreateMobileGeodatabaseView.Model.swift
Outdated
Show resolved
Hide resolved
yo1995
commented
Sep 25, 2024
Shared/Samples/Show device location with NMEA data sources/FileNMEASentenceReader.swift
Show resolved
Hide resolved
philium
reviewed
Sep 25, 2024
Shared/Samples/Show device location with NMEA data sources/FileNMEASentenceReader.swift
Outdated
Show resolved
Hide resolved
Shared/Supporting Files/Extensions/Array+RawRepresentable.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Create mobile geodatabase/CreateMobileGeodatabaseView.Model.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Ridgeway <[email protected]>
…and mark protocol stubs as non isolated.
yo1995
requested review from
philium,
a team and
des12437
and removed request for
a team
philium
reviewed
Sep 25, 2024
Shared/Supporting Files/Extensions/Array+RawRepresentable.swift
Outdated
Show resolved
Hide resolved
Shared/Supporting Files/Extensions/Array+RawRepresentable.swift
Outdated
Show resolved
Hide resolved
Shared/Supporting Files/Extensions/Array+RawRepresentable.swift
Outdated
Show resolved
Hide resolved
Shared/Supporting Files/Extensions/Array+RawRepresentable.swift
Outdated
Show resolved
Hide resolved
AppStorage related changes.
philium
approved these changes
Sep 26, 2024
des12437
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps version numbers to Xcode 16. Related to Esri/arcgis-maps-sdk-swift-toolkit#883
How To Test
Build and run the app on Xcode 16 without error. Xcode 15 won't open the project.