Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus moves to the time-picker popover when clicking input-time-picker's text input #10668

Open
2 of 6 tasks
eriklharper opened this issue Oct 31, 2024 · 1 comment
Open
2 of 6 tasks

Focus moves to the time-picker popover when clicking input-time-picker's text input #10668

eriklharper opened this issue Oct 31, 2024 · 1 comment
Assignees
@geospatialem @DitwanP
Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-11-26 - 3.0....

Comments

@eriklharper
Copy link
Contributor

eriklharper commented Oct 31, 2024 •
edited by jcfranco
Loading

Check existing issues

Actual Behavior

Clicking or triple-clicking the input in input-time-picker automatically moves focus to the first field in the time-picker popover.

Expected Behavior

The time-picker should never gain focus unless it is explicitly clicked or tabbed into. Focus should stay in the input when it is clicked with the mouse.

Reproduction Sample

https://codepen.io/eriklharper/pen/xxvjeze

Reproduction Steps

  1. Left-click with the mouse in the input
  2. Result: focus moves to the hour field in the time-picker popover.

Reproduction Version

next

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@eriklharper eriklharper added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 31, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Oct 31, 2024
@geospatialem geospatialem added regression Issues that are caused by changes in a release, but were working before that. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Nov 12, 2024
@eriklharper eriklharper self-assigned this Nov 12, 2024
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 12, 2024
@jcfranco jcfranco removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 12, 2024
@eriklharper eriklharper mentioned this issue Nov 14, 2024
Merged
@nanzhang01 nanzhang01 mentioned this issue Nov 15, 2024
Open
6 tasks
eriklharper added a commit that referenced this issue Nov 15, 2024
@eriklharper @jcfranco
@benelan @calcite-admin @renovate
fix(input-time-picker): retain focus inside the input when clicked (#…
96e196b 
…10729)

**Related Issue:** #10668

## Summary

This restores the original focus behavior when clicking the input in
`input-time-picker`. Focus remains in the input for typing and selecting
text.

---------

Co-authored-by: JC Franco <[email protected]>
Co-authored-by: Ben Elan <[email protected]>
Co-authored-by: Calcite Admin <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 18, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @eriklharper @geospatialem @DitwanP