fix(input-time-picker): retain focus inside the input when clicked #10729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Related Issue:** #10482 ## Summary - **build: update browserslist db (#10629)** - **docs(angular): update example to use custom elements directly (#10686)** - **build(deps): update dependency @floating-ui/dom to v1.6.12 (#10681)** - **build(deps): update dependency @cspell/eslint-plugin to v8.15.6 (#10680)** - **build(deps): update dependency chokidar to v4 (#10643)** --------- Co-authored-by: Calcite Admin <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* skipped floating-ui.spec > "debounces positioning per instance"
driskull
approved these changes
Nov 14, 2024
|
I'm also in agreement to proceed with this as an internal prop for now. This might be useful for other component authors down the line. Introducing a |
jcfranco
requested changes
Nov 14, 2024
…riklharper/10668-input-time-picker-focus-bug
jcfranco
force-pushed
the
eriklharper/10668-input-time-picker-focus-bug
branch
from
eb9ac44
to
1bb8b68
Compare
github-actions
bot
added
the
bug
…b.com:Esri/calcite-design-system into eriklharper/10668-input-time-picker-focus-bug
…lharper/10668-input-time-picker-focus-bug
jcfranco
approved these changes
Nov 15, 2024
| * Specifies whether focus should move to the popover when the focus trap is activated. | ||
| * `@internal` | ||
| */ | ||
| @property({ type: Boolean }) initialFocusTrapFocus: FocusTargetOrFalse; |
There was a problem hiding this comment.
WDYT about focusTrapInitialFocus? I'll leave it up to you.
There was a problem hiding this comment.
woops, didn't see this comment. Ah well
jcfranco
reviewed
Nov 15, 2024
eriklharper
added
the
pr ready for visual snapshots
eriklharper
deleted the
eriklharper/10668-input-time-picker-focus-bug
branch
github-actions
bot
added this to the 2024-11-26 - 3.0.0 Nov Breaking Change Milestone milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10668
Summary
This restores the original focus behavior when clicking the input in
input-time-picker. Focus remains in the input for typing and selecting text.