Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix a couple release ci issues #7145

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

benelan
Copy link
Member

@benelan benelan commented Jun 6, 2023

Related Issue: #6988

Summary

Fixes a couple release CI issues:

  1. We were going to rename master to main but not sure what happened to that so I changed the branch names back before installing the monorepo PR. However I missed a few in package.json. I think it is still going to happen but I want to wait for Franco to get back before pulling the trigger. cc @alisonailea
  2. Looks like the Action gets out of sync in a real dev environment rather than my isolated testing. I need to pull before pushing the changelog cleaning. Error: https://github.com/Esri/calcite-components/actions/runs/5191460111/jobs/9359307809#step:5:35

@benelan benelan requested a review from a team as a code owner June 6, 2023 21:19
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jun 6, 2023
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 7, 2023
@benelan benelan merged commit f5250f5 into master Jun 7, 2023
@benelan benelan deleted the benelan/release-ci-fixes branch June 7, 2023 01:44
@github-actions github-actions bot added this to the 2023 June patch priorities milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants