ci(release-please): change PR title and ensure git tag consistency #7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
benelan
added
the
skip visual snapshots
benelan
added a commit
that referenced
this pull request
Jun 15, 2023
…import * origin/master: (30 commits) chore: release next fix(radio-button, radio-button-group): prevent emitting events when selecting a checked radio button (#7102) feat(list): Add slots for filter actions (#7148) chore: release next fix(tooltip): improve component timing (#7172) chore: release next fix(input-date-picker): Fix showing the placeholder when resetting the value (#7156) chore: release next fix(input,input-number): allow typing decimal separator in firefox for arabic locale (#7173) build(deps): Bump workbox-build from 6.5.4 to 7.0.0 (#7167) build(deps): Bump type-fest from 3.5.0 to 3.11.1 (#7169) build(deps): Bump chromatic from 6.17.4 to 6.19.5 (#7171) build(deps): Bump @floating-ui/dom from 1.2.9 to 1.3.0 in /packages/calcite-components (#7168) build(deps): Bump @esri/calcite-ui-icons from 3.22.9 to 3.23.1 in /packages/calcite-components (#7166) build: update browserslist db (#7162) ci(release-please): change PR title and ensure git tag consistency (#7153) docs(changelog): Update commit message for #7160 (#7161) chore: release next fix(list): Improve border styling (#7160) chore: release next ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6988
Summary
This PR changes the
release-pleasePR title tochore: release latest. The default ischore: release master.It also makes sure a
visn't added before the version in git tags. Their schema doc says it doesn't by default,but I'm not convinced (see links below) so I want to hardcode the config value. The
vbeing in the tag wouldn't break anything in our CI, but Lerna doesn't add avand we should make sure our tag format is consistent for our consumer's CI.https://github.com/googleapis/release-please/blob/bdd9b0158ce79d958da01ebf54cb6b07925bc125/schemas/config.json#L77-L79
https://github.com/googleapis/release-please/blob/bdd9b0158ce79d958da01ebf54cb6b07925bc125/src/strategies/base.ts#L139