Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support popup sign-in #246

Merged
merged 1 commit into from
Jul 19, 2023
Merged

feat: support popup sign-in #246

merged 1 commit into from
Jul 19, 2023

Conversation

Csmith246
Copy link
Collaborator

No description provided.

@kellyhutchins
Copy link
Member

@Csmith246 the only thing I'm worried about with this PR is the issue with older services and the flow type. I guess we could check the portal version but we might still have issues with older services using the popup workflow. We can test this out to see what happens when older services are used.
Once this is merged we'll want to test on devext to make sure we get the non-popup mode for logging in to apps/data that isn't shared and also check to make sure popup is set correctly for the embed case. unfortunately we can' test the embed workflow on dev/qa due to the sheild page.

@Csmith246 Csmith246 merged commit f7e5d0f into master Jul 19, 2023
@Csmith246 Csmith246 deleted the support-popup-workflow branch July 19, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyhutchins kellyhutchins kellyhutchins approved these changes

@rslibed rslibed Awaiting requested review from rslibed

@bcree11 bcree11 Awaiting requested review from bcree11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Csmith246 @kellyhutchins