Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Reflection probes #10458

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Reflection probes #10458

merged 8 commits into from
Jun 28, 2024

Conversation

dinomut1
Copy link
Member

@dinomut1 dinomut1 commented Jun 26, 2024

Scratchboard for getting reflection probes working. Contains some antipatterns that will be resolved before marking ready for review

[Edit: Linking the Confluence doc]

https://tsu.atlassian.net/wiki/spaces/IREE/pages/2305720326/Reflection+Probes+Spatial+Skyboxes

@dinomut1 dinomut1 force-pushed the reflection-probes branch from 9d97d34 to d82a590 Compare June 26, 2024 19:53
Copy link
Contributor

@Rezmason Rezmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though I'd love to see it in action

dinomut1 added 4 commits June 27, 2024 09:15
add "Bake Probes" button
add resource management and proper cleanup
add single dedicated webgl renderer
@dinomut1 dinomut1 marked this pull request as ready for review June 27, 2024 22:25
@dinomut1 dinomut1 added this pull request to the merge queue Jun 28, 2024
Merged via the queue into dev with commit 3a9c39a Jun 28, 2024
25 checks passed
@dinomut1 dinomut1 deleted the reflection-probes branch June 28, 2024 16:39
MbfloydIR added a commit that referenced this pull request Jun 28, 2024
* dev:
  Reflection probes (#10458)
  standardize IR-Engine Deploy across dev,int,stg; IR-2698 (#10474)
  added scene helpers tools (#10477)
  fix loading screens (#10476)
  [IR-2164] Unit Test - Physics (#10282)
  studio: fix viewport container bg and margin (#10473)
  optimize spline helper (#10295)
  Point & Click Placement Mode (#10042)
  add postprocessing editor back (#10472)
  IR-1579-Resource-tracker (#10423)
  Ir 2790 mouseover tooltip to show fullname (#10456)

# Conflicts:
#	packages/editor/src/services/ComponentEditors.tsx
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants