This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fix scene menu position #10790
Closed
Fix scene menu position #10790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzlamateen
suggested changes
Aug 1, 2024
There was a problem hiding this comment.
https://github.com/theinfinitereality/eepro-multitenancy/pull/352#discussion_r1686384397
@SYBIOTE I dont see it being cut off. Can you ellaboratre it further
Moreover, since this same sceneItem is being used in console, and in console we are opening all context menus to bottom right. Therefore for if in studio its required to be on top, then that can be handled through some prop?
|
it cuts off on smaller screens, like this |
|
@SYBIOTE I can't access the image you referred. Maybe you can provide a property in scene item through which both these behaviors can be supported. |
|
this does not seem relevant anymore, closing the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the position of the scene menu. Previously, the menu was positioned at the bottom of the element, but now it is positioned at the top. This change ensures that the menu is displayed correctly and improves the user experience.
in combination with #10691