Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk: fix build with new DPDK 23.11 #714

Closed
wants to merge 1 commit into from

Conversation

cpaelzer
Copy link
Contributor

@cpaelzer cpaelzer commented Dec 1, 2023

Description

Since 23.03 rte_thread_setname was deprecated and in 23.11 it is gone. Adapt to the new name rte_thread_set_name.
See the release notes for more.

Testing Done

Test build against DPDK 23.11 as it is prepared for Debian and Ubuntu
=> https://launchpad.net/~paelzer/+archive/ubuntu/dpdk-23.11-test-builds/+build/27035932
Build fails without the fix
https://launchpad.net/~paelzer/+archive/ubuntu/dpdk-23.11-test-builds/+build/27035895

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project. See CODING.md.
  • [n/a] I have updated the documentation accordingly.
  • [n/a] I have added tests to cover my changes, and all previous tests pass.
  • [n/a] I have checked all compat numbers if they need updating (FPGA compat, MPM compat, noc_shell, specific RFNoC block, ...)

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Since 23.03 rte_thread_setname was deprecated and in 23.11 it
is gone. Adapt to the new name `rte_thread_set_name`
See [1] for more.

[1]: https://doc.dpdk.org/guides/rel_notes/release_23_11.html

Signed-off-by: Christian Ehrhardt <[email protected]>
Copy link

github-actions bot commented Dec 1, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@cpaelzer
Copy link
Contributor Author

cpaelzer commented Dec 1, 2023

If not strictly required I'd like to save the time to read all the details of the CLA and signing it and instead rely on this term from CONTRIBUTING.md:

Small changes (less than 10 lines of code), or documentation fixes, may be       
accepted without prior submission of a CLA. This decision is made by             
Ettus Research / National Instruments.

Copy link
Contributor

@mbr0wn mbr0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

@mbr0wn
Copy link
Contributor

mbr0wn commented Dec 1, 2023

If not strictly required I'd like to save the time to read all the details of the CLA and signing it and instead rely on this term from CONTRIBUTING.md:

Small changes (less than 10 lines of code), or documentation fixes, may be       
accepted without prior submission of a CLA. This decision is made by             
Ettus Research / National Instruments.

You're good -- thanks again. This patch will percolate our internal CI and review pipelines (potentially with minor modifications) before going live, so don't be surprised if there's a delay between this PR closing and the patch going live.

@atomita-ni atomita-ni closed this Feb 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants