Add a migration for the short-lived intermediate v1 format #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ends up making it a bit easier to test database changes, and it's safe since the migrations always create a new database anyway.
takluyver
reviewed
Jan 20, 2024
damnit/migrations.py
Outdated
| print("If all seems OK, re-run the migration without --dry-run.") | ||
| else: | ||
| db_path = db_dir / DB_NAME | ||
| backup_path = db_dir / "runs.v0-backup.sqlite" |
There was a problem hiding this comment.
Suggested change
| backup_path = db_dir / "runs.v0-backup.sqlite" | |
| backup_path = db_dir / "runs.oldfmt-backup.sqlite" |
Not really significant, but might avoid some confusion if we need to go back to the backup for any reason, to see that this is different from v0.
There was a problem hiding this comment.
Good point, renamed to runs.intermediate-v1-backup.sqlite in 3048e2c.
|
LGTM, and I see in chat that you've been testing it, so presumably we know it works. I wonder if we should have a subcommand a bit like |
JamesWrigley
force-pushed
the
intermediate-migration
branch
from
c8354fa
to
3048e2c
Compare
Like, to check that the files have the right schema/datasets/attributes etc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #151. This allows to migrate the proposals using the original v1 format to the current format. I don't intend to write tests for this migration because it's a one-off for a small number of proposals and I've already tested it on all of them 😛