Watch context file for changes saved separately #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
commented
Aug 1, 2024
Comment on lines
+118
to
+122
| try: | ||
| column_index = self.damnit_model.find_column(name, by_title=True) | ||
| except KeyError: | ||
| log.error("Could not find column %r to set visibility", name) | ||
| return |
There was a problem hiding this comment.
This catch probably isn't needed any more with the fix in damnit_ctx.py, but I figured it was easier to leave it in.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 74.39% 75.32% +0.93%
==========================================
Files 32 32
Lines 4858 5026 +168
==========================================
+ Hits 3614 3786 +172
+ Misses 1244 1240 -4 ☔ View full report in Codecov by Sentry. |
takluyver
changed the title
hcraT
reviewed
Oct 21, 2024
takluyver
force-pushed
the
feat/update-vars-on-save
branch
from
bcf69f7
to
017f173
Compare
hcraT
reviewed
Oct 24, 2024
|
For me LGTM! :) |
|
Thanks! I'll give this another quick try manually, as I've made some changes since I last did, and then I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested interactively. This also fixes a bug where new columns would occasionally show up without a column heading, by ensuring variables always have a title.
cc @tmichela