Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By chance I stumbled upon weird exceptions when you try to use the
in
operator on aDataCollection
. Due to interactions in the Python data model, the absence of a custom__contains__
causes it to try treatingDataCollection
as a sequence...This PR adds proper support for
__contains__
inDataCollection
via a custom magic method. While at it, I also added support for the OR operator for merging (both binary and infix) and excplicitly disabled direct iteration to avoid the issue above.Open questions:
__contains__
allow train ID checks? It is somewhat weird to use, but without it we would not support everything one can pass to__getitem__
__eq__
: somewhat straightforward to add semantically, but probably not useful outside of tests__len__
: which axis to use, trains or sources/keys?__iter__
: Rather iterate explicitly via the provided methods, and avoid weird data model interactions