Expose extra_data components in extra.components #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWrigley
approved these changes
May 22, 2024
|
From a developer perspective, I would probably prefer to move this physically into EXtra, and at most add a link like this PR to EXtra-data. From a user perspective however, this PR is likely more convenient. It may be annoying to update a package, only to learn you need another to keep the functionality. Do we care about the latter case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would avoid people needing to know that some component classes belong to EXtra and others to EXtra-data, if they can import all of them from
extra.components.On the other hand, it could create more confusion if someone ends up with an older EXtra-data package and a newer EXtra, or vice versa, because these classes appear to be part of EXtra, but actually aren't.
I don't have a strong preference, but I figured a PR was a good way to have the discussion.