-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new begin_at_strategy argument and split dataset_obj() #210
base: master
Are you sure you want to change the base?
Conversation
4e3f676
to
7f0aa4c
Compare
- Expose new `begin_at_strategy` calcat argument to switch between closest and prior strategies - Split dataset_obj() deriving path part, as it can be useful to use externally as well.
583a412
to
07f9cc1
Compare
07f9cc1
to
acd9a6c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 71.07% 71.06% -0.01%
==========================================
Files 23 23
Lines 2724 2730 +6
==========================================
+ Hits 1936 1940 +4
- Misses 788 790 +2 ☔ View full report in Codecov by Sentry. |
This MR is ready to review from my side. The coverage tests are a bit rough on me :( I see that there are no |
a931426
to
9d1182a
Compare
I am considering this as a Draft until the pycalibration MR is fully reviewed
begin_at_strategy
calcat argument to switch between prior and closest strategiesThis MR is related to an already almost available change in pycalibration:https://git.xfel.eu/calibration/pycalibration/-/merge_requests/1035/
This is related to that issue as well : https://git.xfel.eu/calibration/planning/-/issues/200 of adding
begin_at_strategy
tocalibration_constant_versions/get_by_detector_conditions
API