[qa] fix test zou/tests/services/test_comments_service.py

EvanBldy · Jun 21, 2024 · 14e3901 · 14e3901
1 parent b42c73b
commit 14e3901
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/tests/services/test_comments_service.py b/tests/services/test_comments_service.py
@@ -104,6 +104,21 @@ def test_manage_status_change(self):
         )
         self.assertTrue(status_changed)
         self.assertEqual(task["retake_count"], 1)
+
+        old_comment = comments_service.new_comment(
+            self.task.id,
+            retake_status["id"],
+            self.user["id"],
+            "old comment",
+            created_at="1999-12-23 10:00:00",
+        )
+        (task, status_changed) = comments_service._manage_status_change(
+            retake_status, task, old_comment
+        )
+
+        self.assertFalse(status_changed)
+        self.assertEqual(task["retake_count"], 1)
+
         (task, status_changed) = comments_service._manage_status_change(
             self.wfa_status, task, comment
         )

diff --git a/zou/app/services/comments_service.py b/zou/app/services/comments_service.py
@@ -138,7 +138,7 @@ def _get_comment_author(person_id):
 def _manage_status_change(task_status, task, comment):
     is_last_comment = (
         task["last_comment_date"] is None
-        or task["last_comment_date"] < comment["created_at"]
+        or task["last_comment_date"] <= comment["created_at"]
     )
     if not is_last_comment:
         status_changed = False