Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing PostgresStreamSubscriptionOptions.Stream to be mutable #236

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

matt-lethargic
Copy link
Contributor

Changing PostgresStreamSubscriptionOptions.Stream to be mutable, this now is more in-line with how the documentation outlines it's usage:

builder.Services.AddSubscription<PostgresStreamSubscription, PostgresStreamSubscriptionOptions>(
    "StreamSubscription",
    builder => builder
        .Configure(x => x.StreamName = "my-stream")
        .AddEventHandler<StreamSubscriptionHander>()
);

but the document should now be:

builder.Services.AddSubscription<PostgresStreamSubscription, PostgresStreamSubscriptionOptions>(
    "StreamSubscription",
    builder => builder
        .Configure(x => x.StreamName = new StreamName("my-stream"))
        .AddEventHandler<StreamSubscriptionHander>()
);

and is now closer to how StreamPersistentSubscriptionOptions is created.

(documentation site will need a PR if this is accepted)

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@alexeyzimarev alexeyzimarev merged commit 3ffed4c into Eventuous:dev Aug 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants