Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 8 (new) #828

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Wartori54
Copy link
Contributor

Second part of #791. This PR builds off of #827.
Remarks:

  • Ideally the NLua submodule should be updated to .NET 8 as well before merging this, but its not strictly required.
  • This change is known to cause issues in regards to code mod building (mods will have to change their TargetFramework entry to net8.0 in order to build with this version of everest), already built mods aren't affected though.
  • MacOS support for low 10.x. versions is unknown currently but the game has been ran on a vm and successfully booted.
  • TASes have been tested against this version and are known to sync.
  • Added a new log statement in order to facilitate the diagnosis of issues related to the runtime version upgrade.

@Wartori54 Wartori54 mentioned this pull request Oct 6, 2024
7 tasks
@Wartori54 Wartori54 changed the title Update to .NET 8 Update to .NET 8 (new) Oct 12, 2024
@maddie480
Copy link
Member

are there any blockers for this?

@maddie480 maddie480 added the discussion Needs input from others label Feb 2, 2025
@Wartori54
Copy link
Contributor Author

The 2nd and 3rd point, which we can't really do much about, we just have accept them, although i could make a updating guide wiki article to send to people that complain about why their mod doesn't build anymore. But saving MacOS sounds kinda hard, everest core already left out some even older versions of MacOS, so i guess its not too bad either, its not our fault apple doesn't provide new updates to their moderately old devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Needs input from others
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants