Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some issues in InternVL family and ScienceQA task. #174

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fixed some issues in InternVL family and ScienceQA task. #174

merged 3 commits into from
Jul 30, 2024

Conversation

skyil7
Copy link
Contributor

@skyil7 skyil7 commented Jul 30, 2024

I found some issues during I evaluate InternVL and InternVL2 on ScienceQA task.

  1. Errors in generate_until()
    • When the input w/o any visual comes in, generate_until returns IndexError because they assume there must be at least one image in the input. So I fixed it.
  2. Result processing code in SQA
    • Missing strip().lower()

@Luodian Luodian requested review from Luodian, pufanyi and kcz358 and removed request for Luodian July 30, 2024 12:21
@Luodian
Copy link
Contributor

Luodian commented Jul 30, 2024 •
edited
Loading

Really nice to see this PR!! Thanks!

May let Kaichen @kcz358 or Fanyi @pufanyi to do the check for internvl's change, if you feel good, can directly merge, thanks!

kcz358
kcz358 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@kcz358 kcz358 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luodian Luodian merged commit 3d4884a into EvolvingLMMs-Lab:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcz358 kcz358 kcz358 approved these changes

@pufanyi pufanyi Awaiting requested review from pufanyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyil7 @Luodian @kcz358